AN Long comments

Results 171 comments of


                                            AN Long

Fix typo word

I think we should have an alias for `ThriftGrammerError` for don't break unit test and users' codes. And maybe we can declare a module level `__getattr__` which descibed in [PEP...

fix the message_type of client

Can you add some basic test cases for this?

pip install thriftpy2 Error

I think you are using GCC4. Please upgrade GCC version.

pip install thriftpy2 Error

@xxd819240366 upgrade GCC to higher version should resolve this issue.

pip install thriftpy2 Error

Cool @chenyanlann , I think we should add a `pyproject.toml` file to specify the third party dependencies' versions which been used when building, like cython.

What if I remove the `while True` loop in TThreadedServer?

I think the server will close connect after handle one request if you remove the look.

WIP: translate socket.timeout to TTransportException

Seems the test cases are excepecting error `socket.timeout`, so this will be a breaking change?

"@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

Python3.5 and former versions is already dead: https://python-release-cycle.glitch.me/ , so I think it's ok to migrate to using `async def`.

"@coroutine" decorator is deprecated since Python 3.8, use "async def" instead

@pearu Hi I saw some answer on stackoverflow, said they have a little different behaviors: https://stackoverflow.com/a/49477233 I think migrate to `async def` is a good choice since Python 3.4 and...

stack smashing while bind on ipv6 port and using wrk to request it

I think wrk is sending some incompatible requests, but meinheld should not exit cause someone may make a DOS attack on it.