redshift_plugin icon indicating copy to clipboard operation
redshift_plugin copied to clipboard

read_and_format doesn't cover all cases

Open szeevs opened this issue 7 years ago • 3 comments

The function is not robust. To cover all cases you need to comply with: https://docs.aws.amazon.com/datapipeline/latest/DeveloperGuide/dp-template-redshift.html

For example, what if you get int(8) from MySQL?

szeevs avatar Mar 22 '18 15:03 szeevs

Very good point @szeevs. This was done quickly to handle a specific implementation but you're absolutely right; it needs to be more robust.

Are you interested in taking this issue?

benjamingregory avatar Mar 22 '18 15:03 benjamingregory

Yes. I will resolve this.

szeevs avatar Mar 22 '18 18:03 szeevs

Great! Just assigned you @szeevs.

benjamingregory avatar Mar 22 '18 18:03 benjamingregory