airbyte icon indicating copy to clipboard operation
airbyte copied to clipboard

✨Source Looker - Migrate Python CDK to Low-code CDK

Open topefolorunso opened this issue 2 years ago • 1 comments

What

Migrate Looker Python CDK to Low-code CDK fixes https://github.com/airbytehq/airbyte-internal-issues/issues/7033

How

Developed using UI Builder and the Low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

topefolorunso avatar Apr 22 '24 07:04 topefolorunso

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 10:50pm

vercel[bot] avatar Apr 22 '24 07:04 vercel[bot]

@topefolorunso can you also run airbyte-ci format fix all to fix the formatting errors?

girarda avatar May 06 '24 22:05 girarda

@natikgadzhi see error encountered

jsonschema.exceptions.ValidationError: The manifest version 3.8.2 is greater than the airbyte-cdk package version (0.90.0). Your manifest may contain features that are not in the current CDK version.

topefolorunso avatar Jul 27 '24 18:07 topefolorunso

@natikgadzhi see error after bumping to CDK 4.0.1 and python = "^3.10,<3.12". could it be the connector base image?

image

topefolorunso avatar Jul 30 '24 02:07 topefolorunso

EZ, set Python in pyproject.toml to ^3.10

natikgadzhi avatar Jul 30 '24 03:07 natikgadzhi

EZ, set Python in pyproject.toml to ^3.10

@natikgadzhi same error

image

topefolorunso avatar Jul 30 '24 11:07 topefolorunso

All good here @natikgadzhi. Please review again

topefolorunso avatar Jul 30 '24 15:07 topefolorunso

@natikgadzhi Regression test passed here

topefolorunso avatar Jul 30 '24 19:07 topefolorunso

Unfortunately, just the run that finished does not mean that the actual test is passed (it's deeper in the reports that I hope I can make public later on).

I'm slow this week, I might be able to merge this, but I'll ask you to be on the lookup for bugs and regressions.

natikgadzhi avatar Jul 31 '24 22:07 natikgadzhi

be on the lookup for bugs and regressions

Got it, I'll be on standby

topefolorunso avatar Aug 01 '24 06:08 topefolorunso