javascript icon indicating copy to clipboard operation
javascript copied to clipboard

`lines-around-directive` rule should replaced with `padding-line-between-statements`

Open mvorisek opened this issue 3 years ago • 9 comments

see https://github.com/eslint/eslint/issues/16629#issuecomment-1341641006 from the eslint maintainer

mvorisek avatar Dec 07 '22 21:12 mvorisek

Hi there,

I want to contribute to this project and take on this issue as my first task. Could you please assign it to me? I am excited to work towards resolving it and will keep the team updated on my progress.

Thanks!

HemanthPaila avatar Mar 31 '23 02:03 HemanthPaila

@HemanthPaila theres no need to request assignment; most open source projects don’t operate that way. Just make a PR and link it to the issue.

ljharb avatar Mar 31 '23 14:03 ljharb

Thanks @ljharb . I am on it.

HemanthPaila avatar Apr 02 '23 02:04 HemanthPaila

I made a PR on this issue. could you please review and merge it?

HemanthPaila avatar Apr 02 '23 03:04 HemanthPaila

Hello sir i made another PR could you please review it once?

HemanthPaila avatar Apr 02 '23 06:04 HemanthPaila

@HemanthPaila please don't make duplicate PRs - now both #2756 and #2757 must remain open and be kept in sync. I've reviewed it, and in the future you don't need to ask for review, you can just wait more than a few minutes :-)

ljharb avatar Apr 02 '23 06:04 ljharb

Sir could you please clarify my doubt: - What I want to add to the issue for a successful merge. - I regret removing the entry, but I will correct the issue by returning it to the appropriate place.

HemanthPaila avatar Apr 02 '23 07:04 HemanthPaila

is the issue resolved?

speedywarp avatar Aug 03 '24 07:08 speedywarp

No, the linked PR, https://github.com/airbnb/javascript/pull/2757, has unresolved comments.

ljharb avatar Aug 06 '24 22:08 ljharb