hypernova-ruby

hypernova-ruby copied to clipboard

Update to Faraday 1.0

11

As the PR #27 I sent a before, Migrating Faraday to 1.x has significant changes. So, I suggest to update the old dependencies and the supported Ruby versions in order...

9toon

YushengLi

Enable plugins to support multiple renderings of same component

1

The current implementation of the plugins feature passes a hash of hypernova-jobs to the callbacks (e.g. `{ 'component_name.js': { :name => 'component_name.js', :data => {} } }`). This makes it...

dpuscher

Escape / and > also so apps cannot be broken by browsers trying to 'correct' the HTML

5

JackMc

zewelor

allow render_react_component(name, props, class: "...")

5

We need to specify HTML `class` attributes to the wrapper div elements. Can you review it please? BTW I can't pass the test (#8) so the CI will fail :(

gfx

to_json is used on request, but JSON.generate is used on blank_renderer which produces inconsistent results

5

When a request is made to https://github.com/airbnb/hypernova the `to_json` method is used: https://github.com/airbnb/hypernova-ruby/blob/ce2497003566bf2837a30ee6bffac700538ffbdc/lib/hypernova/faraday_request.rb#L8 but when the service does not respond, the data is serialized with `JSON.generate` https://github.com/airbnb/hypernova-ruby/blob/ce2497003566bf2837a30ee6bffac700538ffbdc/lib/hypernova/blank_renderer.rb#L24 Theoretically this should...

davidbarratt

Updated README for that version 1.3.0 added third param to plugin on_error. https://github.com/airbnb/hypernova-ruby/blob/master/CHANGELOG.md#added

pinkiebala

Can't use plugins when a certain component has two instances with the same name

2

Hey all, First of all, this is a truly an awesome project! In my project I want to render the same component twice with different props, it works really well...

jtamary

If `render_blank` is called then chances are that something went wrong during rendering and we had to fallback. In development, it would be very nice and useful to surface a...

goatslacker