babel-plugin-inline-react-svg icon indicating copy to clipboard operation
babel-plugin-inline-react-svg copied to clipboard

Register export declaration in scope

Open oleg-rdk opened this issue 6 years ago • 8 comments

Fixes #74

oleg-rdk avatar Apr 11 '20 15:04 oleg-rdk

@oleg-rdk do you plan to revisit this PR? The warning is super annoying =)

pushred avatar Jun 07 '21 20:06 pushred

If not, someone who wants it to land can post a link (not a new PR) to a branch or commit that rebases and accounts for review comments, and I’ll pull it into this PR.

ljharb avatar Jun 08 '21 14:06 ljharb

@ljharb I have pulled @oleg-rdk's branch, rebase it on master and tackle your comments: https://github.com/briganti/babel-plugin-inline-react-svg/commits/fix-declaration-warning

let me know if you need anything, I too need this PR released 🙂

briganti avatar Sep 30 '21 15:09 briganti

@lencioni sorry to drag you in this, but I've noticed you also have contributed to this project. is there anything you can do to make this fix merged? I would really appreciate it.

briganti avatar Jan 05 '22 18:01 briganti

@briganti I haven't gotten to it yet, is all, but will do so soon.

ljharb avatar Jan 05 '22 18:01 ljharb

Would be happy to contribute to this as well! Anything I can do to help this get landed?

merlinaudio avatar Jun 22 '22 11:06 merlinaudio

👋 I'm happy to help too but it seems @briganti's branch is still as ready as ever. So this is just a friendly reminder about this PR that I'd also like to see merged! 😃

simleb avatar Sep 10 '22 00:09 simleb

This PR is now good to go on its own, but is blocked for the same reason as https://github.com/airbnb/babel-plugin-inline-react-svg/pull/116#issuecomment-1235882184.

ljharb avatar Sep 11 '22 05:09 ljharb

@ljharb is this (and https://github.com/airbnb/babel-plugin-inline-react-svg/pull/116) unblocked now that https://github.com/airbnb/babel-plugin-inline-react-svg/pull/117 merged?

simleb avatar Feb 16 '23 23:02 simleb

@ljharb sorry to keep bugging you but would it be possible to tag a new version now that a few PRs (including this one) have been merged?

simleb avatar Feb 22 '23 19:02 simleb

@simleb i just got permissions sorted out yesterday so that i can release; i'll try to do that in the next couple days.

ljharb avatar Feb 22 '23 19:02 ljharb

v2.0.2 is released.

ljharb avatar Feb 23 '23 07:02 ljharb