Tayfun Bocek
Tayfun Bocek
Sounds good! There is a few parts that I am not exactly happy about, such as not using an enum like the older PR. I have explained the reasons why...
I definitely agree that using an enum allows us express things better in this case. There is a few reasons why I decided not to go through with it: -...
Found a possible panic when a column is selected, but the provided widths were less than the column count. Fixed, and added testing for the case. It now uses safe...
I don't mean to rush the review, but is there anything blocking this? Should I replace the `selected_column`, and `selected` fields with an enum? I just wanted to check if...
> Will this enable scrolling columns as well if they are wider than the bounding container? Sadly no. The linked issue has some context on why it was not included...
Thats essentially whats happening, with the flattened `HashMap` in `InnerCfg`. To do this we create a seperate struct with the field we want flattened being replaced by the `HashMap`. After...
@MarcusGrass in case you want to check it out. :)
Can a maintainer assign this to me? I am thinking of making two separate PR's, one for applying styles for the selected column and one for allowing to set the...
I want to give a little update on my progress. Column selection, column highlighting, and cell highlighting are done. These are mostly ready for a PR. ## Problem: I am...
I could have been more clear in my second question. When rendering the rows, we get the start and end bound of what can and should be rendered. My idea...