aion icon indicating copy to clipboard operation
aion copied to clipboard

Block Propagation output insufficient

Open qoire opened this issue 7 years ago • 0 comments

Currently block propagation outputs the following:

18-03-02 14:21:59.520 DEBUG SYNC [p2p-write]: sending new block51f03d to: 2044142099
18-03-02 14:21:59.520 DEBUG SYNC [p2p-write]: sending new block51f03d to: 1441608361
18-03-02 14:21:59.520 DEBUG SYNC [p2p-write]: sending new block51f03d to: 1881202134
18-03-02 14:21:59.520 DEBUG SYNC [p2p-write]: sending new block51f03d to: -296437860
18-03-02 14:21:59.520 DEBUG SYNC [p2p-write]: sending new block51f03d to: 1542405440
18-03-02 14:21:59.538 DEBUG SYNC [p2p-write]: blockProp: [node: -39373317 | hash: 51f03d | status: PROP_CONNECTED]
18-03-02 14:21:59.545 DEBUG SYNC [p2p-write]: blockProp: [node: 1441608361 | hash: 51f03d | status: DROPPED]

Other than the state, the shortened hash is not useful for the user to query, and it is lacking numbers. Update to shorten the sending block message to something more like:

sending new block: num=<number>, hash=<fullHash> to nodeIdShortHash

Response message can be:

blockProp: [node: <shortIdNodeHash> | num: <number> | hash: 51f03d | status: PROP_CONNECTED]

qoire avatar Mar 02 '18 14:03 qoire