add flag support

[thehesiod]

adds Client arg for method to decode values which have flags

[codecov[bot]]

Codecov Report

Merging #92 into master will increase coverage by 0.8%. The diff coverage is 93.33%.

@@           Coverage Diff            @@
##           master     #92     +/-   ##
========================================
+ Coverage    91.5%   92.3%   +0.8%     
========================================
  Files           5       6      +1     
  Lines         259     286     +27     
  Branches       38      44      +6     
========================================
+ Hits          237     264     +27     
  Misses         11      11             
  Partials       11      11

Impacted Files	Coverage Δ
aiomcache/__init__.py	100% <ø> (ø)	:arrow_up:
aiomcache/helpers.py	100% <100%> (ø)
aiomcache/client.py	88.65% <77.77%> (+0.36%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 692e2c0...53699a3. Read the comment docs.

[thehesiod]

btw another option is adding a client wrapper what will do the right thing

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Dreamsorcerer]

I'm not so familiar with these flags. But, would you still be interested in updating the PR to get this merged?

[thehesiod]

rebasing now

[thehesiod]

@Dreamsorcerer where are we with this? :)

[Dreamsorcerer]

@Dreamsorcerer where are we with this? :)

I have 100+ tabs open for things to get back to. :P I had a couple of open questions about the implementation: https://github.com/aio-libs/aiomcache/pull/92#discussion_r851634105

If you can answer any of those questions, I'll try and look at it in a moment.

[thehesiod]

@Dreamsorcerer where are we with this? :)

I have 100+ tabs open for things to get back to. :P I had a couple of open questions about the implementation: #92 (comment)

If you can answer any of those questions, I'll try and look at it in a moment.

cool thanks, i just realized I never got back to your PR too, we'll get that merged today. Finally got our house back together after 6mo! lol

[Dreamsorcerer]

OK, I'm all caught up now. So, if you want to merge https://github.com/thehesiod-forks/aiomcache/pull/1 into your branch, then we need to fix up the 2 remaining errors reported by mypy.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 29a6f1e263368d545aea13bf4782a071adc488ff into 2b5460ae17cb7be73ef66c235fe43387515d83a1 - view on LGTM.com

new alerts:

• 1 for Unused import

[jayzfbn]

@Dreamsorcerer I attempted to clean up the lint errors and also merged your latest changes from master. Please let me know if any other issues. I think this is my first contribution on this account I need an extra approval. thx!

[lgtm-com[bot]]

This pull request introduces 1 alert when merging c4fcfc7faa7fb5e72ca1cc0547367e09bcf0ee9b into 2b5460ae17cb7be73ef66c235fe43387515d83a1 - view on LGTM.com

new alerts:

• 1 for Unused import

[Dreamsorcerer]

As we're finishing up this PR, we should also get an example in the README for how this is used.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging f56053eb7083b7a607bdd846a88e3fb410274712 into 7c52d8c8318ca6ce355fa8b9b8047b2c830d9cb7 - view on LGTM.com

new alerts:

• 1 for Unused import

[Dreamsorcerer]

Umm, I bumped the pylibmc version because it didn't support 3.11, but seems several tests are now failing. That's a little worrying..

[Dreamsorcerer]

As we're finishing up this PR, we should also get an example in the README for how this is used.

Maybe a complete example under examples/ and then a summary or mention of that example in the README..

[lgtm-com[bot]]

This pull request introduces 1 alert when merging bf26564863093af35f71633641fe67b6169f97dd into 7c52d8c8318ca6ce355fa8b9b8047b2c830d9cb7 - view on LGTM.com

new alerts:

• 1 for Unused import

[jayzfbn]

I will take a look at the failing tests with the new pylibmc. Separately, the unclosed socket errors I was able to duplicate locally and they seem to be addressed by adding some connection release/cleanup to the other tests. Re: 294

[jayzfbn]

Investigating this I discovered that in pylibmc the behavior changed from 1.5.2 to 1.6.3 such that stored boolean values are no longer returned as booleans but instead as ints. I'm consulting with @thehesiod as to whether we should just drop the pylibmc references all together or move to the new behavior.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 65686d30fe606c884aa3121c6e26071e51a0b292 into 56d1377cea9c229dfceb77fcfe7d881dade01454 - view on LGTM.com

new alerts:

• 1 for Unused import

[Dreamsorcerer]

Separately, the unclosed socket errors I was able to duplicate locally and they seem to be addressed by adding some connection release/cleanup to the other tests. Re: 294

Got a PR for that?

[jayzfbn]

| Got a PR for that?

It's in this PR. I'm off today but I'll sit down and take another spin at this on Monday and try to address the remaining comments.

[Dreamsorcerer]

| Got a PR for that?

It's in this PR. I'm off today but I'll sit down and take another spin at this on Monday and try to address the remaining comments.

Right, I missed the first set of commits. Weird that the failing test is not the one that got updated (or even the before the failing test)...

[jayzfbn]

I think my last commit should address the open comments. I also added some tests just for my own sanity.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 6d241831877e6724f2cb756bad1b3647f7e154d2 into 2aac5e504a15cfdedc0df3712936de7af4dd7d1f - view on LGTM.com

new alerts:

• 1 for Unused import

---

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging c04c6d230b4370025674da1f8dc4931c1f5413dd into cc2a55a1736133a435d8448391238341f4f4fff5 - view on LGTM.com

new alerts:

• 1 for Unused import

---

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 36cb8484f54102cb4307b2a0ed3c30b8d68410ad into cc2a55a1736133a435d8448391238341f4f4fff5 - view on LGTM.com

new alerts:

• 1 for Unused import

---

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed :rocket:. For more information, please check out our post on the GitHub blog.

[Dreamsorcerer]

Thanks for that, finally got through it all.

[jayzfbn]

Thanks a bunch for the merge; no urgency on any of this but is a release version rev on the radar any time soon? Totally fine waiting a bit if one is coming sometime soon anyway, just thought I would check. Thx!

[Dreamsorcerer]

Yep, I'll do it this week. Was hoping someone might verify and fix #111 before I did a release.

[jayzfbn]

No rush; thanks a bunch!