aiohttp icon indicating copy to clipboard operation
aiohttp copied to clipboard

Abort the transport for all connections if enable_cleanup_closed is true

Open krizex opened this issue 5 years ago • 3 comments

What do these changes do?

When closing the connector, only the connections which are closed abort the transport. The connections which are available or acquired do not abort the transport.

This commit fixes the issue.

Are there changes in behavior for the user?

Nope

Related issue number

Checklist

  • [x] I think the code is well written
  • [x] Unit tests for the changes exist
  • [x] Documentation reflects the changes
  • [x] If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • [x] Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

krizex avatar Jan 14 '21 07:01 krizex

Codecov Report

Merging #5406 (073f51b) into master (1520b8f) will decrease coverage by 0.46%. The diff coverage is 100.00%.

:exclamation: Current head 073f51b differs from pull request most recent head 92972fa. Consider uploading reports for the commit 92972fa to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5406      +/-   ##
==========================================
- Coverage   97.17%   96.71%   -0.47%     
==========================================
  Files          41       41              
  Lines        8865     8746     -119     
  Branches     1425     1405      -20     
==========================================
- Hits         8615     8459     -156     
- Misses        133      150      +17     
- Partials      117      137      +20     
Flag Coverage Δ
unit 96.68% <100.00%> (-0.39%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/connector.py 96.25% <100.00%> (-0.26%) :arrow_down:
aiohttp/http_websocket.py 95.95% <0.00%> (-2.70%) :arrow_down:
aiohttp/web_protocol.py 84.39% <0.00%> (-2.03%) :arrow_down:
aiohttp/web.py 97.41% <0.00%> (-1.74%) :arrow_down:
aiohttp/helpers.py 95.77% <0.00%> (-1.06%) :arrow_down:
aiohttp/http_parser.py 96.49% <0.00%> (-0.97%) :arrow_down:
aiohttp/web_exceptions.py 98.57% <0.00%> (-0.95%) :arrow_down:
aiohttp/test_utils.py 98.75% <0.00%> (-0.93%) :arrow_down:
aiohttp/web_response.py 97.61% <0.00%> (-0.60%) :arrow_down:
aiohttp/client_reqrep.py 97.37% <0.00%> (-0.49%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1520b8f...92972fa. Read the comment docs.

codecov[bot] avatar Jan 14 '21 07:01 codecov[bot]

Hi @webknjaz @asvetlov Can you please have a look at this change?

krizex avatar Jan 27 '21 02:01 krizex

This PR seems to have got missed, but I'm not really clear on what it's doing, or what it's trying to solve.

Dreamsorcerer avatar Sep 09 '24 22:09 Dreamsorcerer