RectangleWin icon indicating copy to clipboard operation
RectangleWin copied to clipboard

Add a YAML config based configuration path. Adds alternative bindings for corner functions, max-height function and make larger/smaller

Open phoeagon opened this issue 5 months ago • 6 comments

Enhance rectangleWin to have the following features:

  1. default corner key binding with ctrl-alt-U|I|J|K.
  2. ctrl-alt-shift-UP: make the current window take the full height of screen.
  3. ctrl-alt-+ make current window larger.
  4. ctrl-alt-- make current window smaller. All these bindings are the same as default rectangle on Mac when used with a Windows keyboard.

phoeagon avatar Aug 31 '25 08:08 phoeagon

Adds a yaml based config workflow. Minor changes to main.go to ensure console outputs are preserved as well.

phoeagon avatar Sep 02 '25 06:09 phoeagon

These are all good but I think we should try to split into smaller PRs so I can adequately review.

Also it might be good to send a proposal issue first so we can discuss. What do you think?

ahmetb avatar Sep 07 '25 03:09 ahmetb

Any interest in splitting the PR?

ahmetb avatar Sep 09 '25 05:09 ahmetb

Sure! Please let me know how you would like the change structured. There are a few generally orthogonal things:

  1. config yaml
  2. additional functions (maxheight, etc)
  3. fixing github workflows, etc. I've opened an FR... (oh I see you mean open a PR not FR). do you have a strong opinion on each of these? Thanks!

phoeagon avatar Sep 09 '25 05:09 phoeagon

Created 2 separate FRs. Please let me know if you would like to have the maxheight, etc, features added without the configuration feature. That would require a bit of rewriting and reverting on my end to reproduce the results. Thanks!

phoeagon avatar Sep 09 '25 06:09 phoeagon

@ahmetb I've moved this to https://github.com/ahmetb/RectangleWin/pull/14 which might be cleaner, especially for github workflows that might not be easy to integrate back. (Please feel free to close this one and use https://github.com/ahmetb/RectangleWin/pull/14 for review) (for clarity, I'm responding to the comments here as well)

phoeagon avatar Sep 22 '25 04:09 phoeagon