sqlacodegen icon indicating copy to clipboard operation
sqlacodegen copied to clipboard
verified publisher icon agronholm

Double pluralization of names

Open dkratzert opened this issue 2 years ago • 7 comments

Fixes #260 Stop double pluralization of names

  • The proposal in #260 had the problem that inflect_engine.singular_noun() can be False, e.g. for inflect_engine.singular_noun('version')

dkratzert avatar Mar 22 '23 12:03 dkratzert

Coverage Status

Coverage: 97.663% (+0.2%) from 97.425% when pulling d2725f2da99690ce3e58981d02ab73cddfdc4c00 on dkratzert:double-pluralization-of-names into f8e377785879f3e1cc3a8b2d5f19e8d3d3ac4454 on agronholm:master.

coveralls avatar Mar 22 '23 12:03 coveralls

Regarding the first test, simple_item = relationship('SimpleItem', back_populates='container') is not correct because the related foreign key column does not have a unique constraint on it.

agronholm avatar Aug 05 '23 14:08 agronholm

@dkratzert thanks for this PR. Are you still planning to get this merged?

NixBiks avatar Nov 16 '23 10:11 NixBiks

Sorry for the delay! I hope to have time for it soon.

dkratzert avatar Nov 16 '23 10:11 dkratzert