ResourcePackConverter icon indicating copy to clipboard operation
ResourcePackConverter copied to clipboard

OptiFine CIT Doesn't support enchantments

Open Cxrrlos opened this issue 4 years ago • 19 comments

It has converted everything nicely, though my custom textures do not work after the conversion.

The mcpatcher --> cit has changed and become optifine --> cit, though the textures do not work.

(more info on these textures: I had some of when armour was at a certain hp, it changed to look more broken, I also had different textures for sharpness 5 swords)

This was a 1.8 to 1.16.5 conversion, though these textures also worked on 1.12.2 before.

Cxrrlos avatar Jun 28 '21 14:06 Cxrrlos

Can you give me one of your CIT .properties files so I can take a look and see if I need to make any changes?

CoryBorek avatar Jun 28 '21 16:06 CoryBorek

This is for a diamond sword, when its sharpness 5 it should normally change the texture (Im not sure why the # date and # are there, I didnt put them)

Also, the name of this file is: opsword.properties (I couldnt just drag it here because it says it doesnt support the .properties file type)

#Mon Jun 28 00:21:28 CEST 2021 items=276 enchantmentLevels=5 type=item enchantmentIDs=16 texture=opsword.png

Cxrrlos avatar Jun 28 '21 16:06 Cxrrlos

And where is opsword.png located? in the same folder as opsword.properties?

CoryBorek avatar Jun 29 '21 23:06 CoryBorek

Yes, I believe its all in the same folder. The mcpatcher --> cit is now optifine --> cit, but all the pngs and .properties are in the same cit folder like they used to be.

Cxrrlos avatar Jun 30 '21 08:06 Cxrrlos

so the pngs and properties are in mcpatcher --> cit and not optifine --> cit?

CoryBorek avatar Jul 01 '21 16:07 CoryBorek

now there is no folder called mcpatcher, to get to the cit folder, I do assets --> minecraft --> optifine --> cit

Cxrrlos avatar Jul 01 '21 17:07 Cxrrlos

oh okay. there may have been changes to optifine then. I know this system used to work in 1.13

CoryBorek avatar Jul 01 '21 18:07 CoryBorek

So, is there any way to get it to work? Even if its manually?

Cxrrlos avatar Jul 01 '21 18:07 Cxrrlos

I'd have to look into the changelogs for optifine. If it's something fixable, I can implement changes relatively easily

CoryBorek avatar Jul 01 '21 23:07 CoryBorek

Quick question, Try removing the .png from the image replacement text and see what happens?

CoryBorek avatar Jul 01 '21 23:07 CoryBorek

Im not sure what you mean by: "image replacement text". Do you mean changing the file name to not be a .png?

I have removed the .png and edited the .properties document to look for the new file name. (So, in the .properties I have changed it to texture=opsword)

It still doesnt seem to be working.

Cxrrlos avatar Jul 02 '21 15:07 Cxrrlos

Don't remove the .png from the file itself, just the reference in the .properties file

CoryBorek avatar Jul 02 '21 16:07 CoryBorek

It still is not working

Cxrrlos avatar Jul 02 '21 17:07 Cxrrlos

I'll have to look at the optifine changelog then.

CoryBorek avatar Jul 02 '21 19:07 CoryBorek

Update: The software doesn't currently change enchantment ids. That will probably have to be fixed

CoryBorek avatar Jul 02 '21 19:07 CoryBorek

Though, I think this is not only enchantments because none of the others change. ( I have one for when armour was at a certain hp, it changed to look more broken )

Cxrrlos avatar Jul 02 '21 20:07 Cxrrlos

This will not be worked on until #68 is finished. I'd like all the OptiFine and other mod changes to be moved over to Extensions, as that will make it easier for other mods to be worked on. Will only fix any major issues of stuff currently implemented.

CoryBorek avatar Dec 08 '21 02:12 CoryBorek

Most likely will move away from supporting CIT in the future. Will leave open until a final decision is made.

CoryBorek avatar Jun 19 '24 20:06 CoryBorek

I hope not, a lot of 1.8 packs use CIT and this converter would be huge for the 1.8 community, already shared it to a lot of people I know, including 1.8 pack makers

lowercasebtw avatar Jun 19 '24 20:06 lowercasebtw