angular2-websocket icon indicating copy to clipboard operation
angular2-websocket copied to clipboard

Replace es6-shim with core-js

Open jdonenine opened this issue 9 years ago • 4 comments

Recently Angular2 removed their dependency on the es6-shim module so that core-js could be used in it's place. The es6-shim module has licensing issues which prevent it from being commercially distributed. Would it be possible to change your dependency to be on the core-js shim library instead of es6-shim?

jdonenine avatar Jun 30 '16 13:06 jdonenine

Could you please create a pull request?

afrad avatar Jun 30 '16 19:06 afrad

Done. https://github.com/afrad/angular2-websocket/pull/21

jdonenine avatar Jul 01 '16 14:07 jdonenine

I'm using ionic 2 and it's starters don't come with core-js, but it looks like it does do polyfills somehow. Maybe just remove the peer dependency?

jb-int avatar Feb 03 '17 14:02 jb-int

Ionic 2 also can't do Typescript 2.1+ yet. It's stuck on 2.0.9. Can you lower the dependency or does it really need to be 2.1+?

jb-int avatar Feb 03 '17 14:02 jb-int