Ammar Yasser
Ammar Yasser
as it stands, a good majority of what this project does is being a wrapper around gocli commands, is the goal to: - write another wrapper over gocli that sends...
@xpivarc Thanks for the clarifications, and i do agree with you on the points you mention about the lack of a need to check for virtualization and pass the container...
@xpivarc i have sent you an initial version of the proposal on slack, please check it and let me know if you have any suggestions
@victortoso I suggest we create a base struct and embed it in the specific device plugin structs. and implement the generic methods on this inner struct. If a specific device...
hello @victortoso I have reached on what i believe is a good enough version of this refactor on all device plugins. First of all i have made the interface to...
Hey victor, thanks alot for showing me how this is tested. my only guiding metric was the compiler not complaining about missing method implementations on interfaces or invalid fields. but...
@alicefr @victortoso this has been fixed now, the newly defined file just wasn't included in bazel, check the changes on BUILD.bazel to see what i did. what else is needed...
This by definition requires extension of the `FakePlugin` used in testing, let me know what you guys think. i edited the code to use the interface you already have
Hello @alicefr Rewrote the history as you see, please let me know if this fits a linear narrative or you have any further suggestions
/retest