aep-dev
Adopt AEP 231 - Batch Get
Adopt AEP 231 - Batch Get
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an x in the boxes
that apply
- [ ] Enhancement
- [ ] New proposal
- [X] Migrated from google.aip.dev
- [ ] Chore / Quick Fix
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for contributing to this repository.
General
- [X] Basic Guidance is met.
- [X] Ensure that your PR references AEPs correctly.
- [X] My code has been formatted
(usually
prettier -w .)
Additional checklist for a new AEP
- [X] A new AEP should be no more than two pages if printed out.
- [X] Ensure that the PR is editable by maintainers.
- [X] Ensure that File structure guidelines are met.
- [X] Ensure that Document structure guidelines are met.
💝 Thank you!
@rofrankel Thanks for the re-review. I addressed your comments and asked for a new review.
I made the updates we discussed three weeks ago. Please re-review and let me know if there is any additional feedback.
@rofrankel Thanks for the comments. I've addressed or answered all that I could. I will need help on the proto definition of the response.
I will tag you for re-review.
Thank you for the review and suggestions @toumorokoshi. I accepted all these. Is there anything else to do or can we merge this now?