aeharding
Added default comment sort option.
Added the ability to set a default sort type for comments in the appearance menu, as it was a personal pet peeve of mine to have comments sorted to hot by default.
resolves #43
Nice work! Been wanting this feature and learned something reading through the PR!
Thanks @Faalangst26 for keeping this up to date with main.
We will hopefully get the storage stuff in tomorrow (🤞) and then unblock this
@Faalangst26 The DB work is done, so this should be ready to merge once conflicts resolved and updated to use the new db service! :)
Let me know if you have time in the next few days! Thank you!
I'm on holiday at the moment, so I won't be able to resolve until I get back. You can close it if you want someone else to implement it in the meantime.
@Faalangst26 I resolved the conflicts but I can't push them here, should I open a PR onto your branch, open a new PR replacing this one, or I could let @aeharding push the changes to your branch if he would like to. I pushed it to https://github.com/rsammelson/wefwef/tree/default-comment-sort.
@rsammelson I could merge it with this one if you open a PR with my branch. Alternatively you could just open a new PR on this repo and mention this one so it can get merged with main.
Thanks for the pr. I'd like to get this in tomorrow if you have time.
Just checked - The appearance settings page needs some work. Tapping one of the options blanks out the page and the options are grouped strangely.
Also, sort isn't really an appearance setting. We should really make a general settings page. However, I'm fine merging this once the above gets resolved and we can fix this as part of a larger settings page refactor :)
I've resolved conflicts, moved the setting to a new general page, and refactored a few things.
This should now be pretty much ready. If anyone want to test that would be appreciated.