aeharding
Allow showing downvotes separately or hiding scores
Fixes #170 and fixes #135. When the setting is in the default mode, it should work the same as before.
I accidentally ended up with this branched off of my changes from #209, so I'm going to wait until that is merged to get this one ready to merge.
@rsammelson I made some adjustment here, if you want to cherrypick or I can PR to yours.
https://github.com/aeharding/voyager/commit/aea3ff8e17b0ab2d8ef969f4a59b0f104b4793ab
I just saw your comment, I must have started working on it at the same time as you. I brought over some more changes from your commit in the most recent push.
Oh oops!
Can we keep "cumulative"? I have that in e8861fbd41be170f8b834d0d21f6a2122f19a023 and I would add it but it looks like I don't have permission to push to your branch.
Yeah I can change it, I called it "net score" though which seems more precise
"Total" would also work. I want to leave off "Score" though because it's not consistent with the other options to add for that one only
Do you know if there's some config you can adjust so I may push to this branch?
Yeah it's a setting on my end but it says "access to secrets":
Which sounded scary so I didn't check it.
Yeah on reading the help page the secrets can only possibly give modify access to other branches of the same repo, so it's not actually a security issue in this case
When I rebased on to main a while ago I forgot to apply the cleanup I did to the new settings.
Thanks. This looks good. I wonder if the downvotes should be hidden if none in separate mode. In the comments it gets a little busy with a bunch of zeroes that are not necessary. that's something for another pr though