Hyperion
Hyperion copied to clipboard
Fix(calendar factory): No uppercase
Description
Summary
I messed up my local db by running the test workflow on it, so I dropped it, created it, ran the factories, tried to create a calendar event for a future PR, and I got a 500 because the db had "Approved" instead of Decision.approved.value whose value is "approved".
Changes Made
- [x] Use a value
Classification
Type of Change
- [x] 🐛 Bug fix (non-breaking change which fixes an issue)
- [ ] ✨ New feature (non-breaking change which adds functionality)
- [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
- [ ] 🔧 Infra CI/CD (changes to configs of workflows)
- [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
- [x] 😶🌫️ No impact for the end-users
Impact & Scope
- [ ] Core functionality changes
- [x] Single module changes
- [ ] Multiple modules changes
- [ ] Database migrations required
- [x] Other: Factory
Testing
- [x] 1. Tested this locally
- [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork)
- [ ] 3. Tested in a deployed pre-prod
- [ ] 0. Untestable (exceptionally), will be tested in prod directly
Documentation
- [ ] Updated the docs accordingly :
- [ ]
"Docstrings - [ ]
#Inline comments - [x] No documentation needed
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 52.30%. Comparing base (52e0872) to head (4ec11c1).
:warning: Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #905 +/- ##
===========================================
- Coverage 85.89% 52.30% -33.59%
===========================================
Files 193 193
Lines 14954 14954
===========================================
- Hits 12844 7822 -5022
- Misses 2110 7132 +5022
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.