Hyperion icon indicating copy to clipboard operation
Hyperion copied to clipboard

Misc Contacts for PE5

Open warix8 opened this issue 10 months ago • 3 comments

Description

This PR add a miscellaneous module for some stuff. It adds contacts information for a website from PE5 to protect information about contact on the campus such as phone, number, location in order to not leak them on Internet directly.

Checklist

  • [x] Created models
  • [x] Created schemas
  • [x] Created cruds
  • [x] Created endpoints
  • [x] All tests passing

warix8 avatar Apr 10 '25 09:04 warix8

Codecov Report

Attention: Patch coverage is 96.80851% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (001b352) to head (f9cc150).

Files with missing lines Patch % Lines
app/modules/misc/cruds_misc.py 93.10% 2 Missing :warning:
app/utils/auth/providers.py 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   81.88%   82.00%   +0.12%     
==========================================
  Files         152      156       +4     
  Lines       10862    10956      +94     
==========================================
+ Hits         8894     8985      +91     
- Misses       1968     1971       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 10 '25 10:04 codecov[bot]

Consider writing in code comments that it is instead for the future "satefy cards" website... few know the context! Saying that "safety cards" website = PE5 here in the discussion is enough.

Also, where is the AuthClient to authenticate via MyECL ?

Marc-Andrieu avatar Apr 10 '25 10:04 Marc-Andrieu

Last but not least: a (super)module for miscellaneous small (sub)modules sounds like a good idea to me (see others in Titan), but it may create lengthy discussions to actually create it.

Marc-Andrieu avatar Apr 10 '25 11:04 Marc-Andrieu