password requirements
Description
update our password validators to unsure new users' password are strong enough. We need to coordinate this with Titan.
Fix: #330
Codecov Report
Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
Project coverage is 82.90%. Comparing base (
57670d0) to head (20740ea). Report is 1 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| app/utils/validators.py | 77.77% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 82.87% 82.90% +0.02%
==========================================
Files 98 98
Lines 6185 6199 +14
==========================================
+ Hits 5126 5139 +13
- Misses 1059 1060 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13092605 | Triggered | Generic Password | 87ad009268ba145614105735cc8df1c89363ea36 | tests/test_users.py | View secret |
| 13092606 | Triggered | Generic Password | 87ad009268ba145614105735cc8df1c89363ea36 | tests/test_users.py | View secret |
| 13092607 | Triggered | Generic Password | 87ad009268ba145614105735cc8df1c89363ea36 | tests/test_users.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.