Hyperion icon indicating copy to clipboard operation
Hyperion copied to clipboard

Module/raid registering

Open maximeroucher opened this issue 1 year ago • 5 comments

Description

Adding the back end support for the Raid event registration

Checklist

  • [ ] Created tests which fail without the change (if possible)
  • [ ] All tests passing
  • [ ] Extended the documentation, if necessary

maximeroucher avatar Feb 25 '24 14:02 maximeroucher

Quick note: please be careful when using get_file_from_data() and save_file_as_data() 😉

Comment says: WARNING: **NEVER** trust user input when calling this function. Always check that parameters are valid.

Currently, your document_id is directly controlled by the user. As it is, it would be a major security flaw.

Petitoto avatar Feb 26 '24 10:02 Petitoto

Yes, this is just a placeholder, the function done are tagged with Tags.raid for now

maximeroucher avatar Feb 26 '24 11:02 maximeroucher

Codecov Report

Attention: Patch coverage is 75.56452% with 303 lines in your changes missing coverage. Please review.

Project coverage is 81.81%. Comparing base (c0ac46e) to head (cb24267). Report is 1 commits behind head on main.

Files Patch % Lines
app/modules/raid/endpoints_raid.py 78.68% 68 Missing :warning:
app/modules/raid/cruds_raid.py 70.43% 55 Missing :warning:
app/modules/raid/utils/pdf/pdf_writer.py 70.55% 53 Missing :warning:
app/modules/raid/utils/utils_raid.py 52.57% 46 Missing :warning:
app/modules/raid/utils/drive/drive_file_manager.py 51.56% 31 Missing :warning:
app/modules/raid/models_raid.py 81.13% 30 Missing :warning:
app/modules/raid/utils/pdf/conversion_utils.py 56.52% 20 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   82.76%   81.81%   -0.95%     
==========================================
  Files         115      125      +10     
  Lines        8227     9469    +1242     
==========================================
+ Hits         6809     7747     +938     
- Misses       1418     1722     +304     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 15 '24 23:03 codecov[bot]

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Apr 01 '24 11:04 gitguardian[bot]

We need to merge https://github.com/aeecleclair/Hyperion/pull/510 first

armanddidierjean avatar Aug 19 '24 18:08 armanddidierjean