rubyvideo icon indicating copy to clipboard operation
rubyvideo copied to clipboard

Implementation of RSS and Atom feeds

Open krapans opened this issue 2 years ago • 4 comments

Both feeds were validated by https://validator.w3.org/feed/. Can be down by using snapshots from tests as well.

RSS

image

Atom

image

Closes #12

krapans avatar Jun 25 '23 15:06 krapans

This looks awesome to me. I was wondering if we really need a feed route/controller vs using the existing talks_controller / route.

The advantage I see using the talks_controller is we could use the filtering https://github.com/adrienpoly/rubyvideo/issues/3 once they are available. And provide a feed icon for every search result. So you could add to your feed Railsconf only by example.

Not a big RSS user so not sure how people are using this

adrienpoly avatar Jun 25 '23 16:06 adrienpoly

@adrienpoly, kind of makes sense that we would move it to talks controller, I don't see any problems with that. The only concern that I would have I guess is that @pagy object would be ignored in case of RSS, because it kind of wouldn't fit in that structure.

Only worry is here that we have a one entrypoint, though some formats would use @pagy object and some like RSS/Atom wouldn't. Not sure though if its a dealbreaker.

krapans avatar Jun 25 '23 16:06 krapans

@krapans sorry to bother you with that but I made an error trying to rebase the branch and deleted some codes. If you still have the branch locally can you open a new PR. Sorry about that !

adrienpoly avatar Oct 20 '23 06:10 adrienpoly

@krapans ok I could recover the missing file. Test suite is green now will give it a final test before merge thanks

adrienpoly avatar Oct 23 '23 07:10 adrienpoly