rubyvideo icon indicating copy to clipboard operation
rubyvideo copied to clipboard

Explore all talks recorded at event card

Open justinallenmarsh opened this issue 1 year ago • 1 comments

fixes #180

I left out the event city and country because the current seed data doesn't contain this information. I have added a link to the event at the bottom of every talk#show view and have styled it responsively to match the design in the issue.

There is also not an event image so I just included the talk thumbnail. (This should probably be fixed)

https://github.com/user-attachments/assets/ef746f3a-4124-4600-bf30-169726690f3f

justinallenmarsh avatar Oct 03 '24 14:10 justinallenmarsh

@marcoroth @adrienpoly I think if this were up to me I think that the header above the list of talks from the same event should be a link. Instead of "RailsConf 2024" it could be "Explore all talks from RailsConf 2024" and the hover over could be a link (an image can be added afterward).

https://github.com/user-attachments/assets/a15451b3-b1c3-42c8-8241-c1cc8016f00b

justinallenmarsh avatar Oct 04 '24 10:10 justinallenmarsh

I think for now we should remove all images until we have a proper Event image

I think I agree with this. If we just have the name of the event, maybe the description, and the speaker avatars we should be good to start with.

marcoroth avatar Oct 22 '24 18:10 marcoroth

I think this combined with #226, is already a good starting point.

justinallenmarsh avatar Oct 22 '24 18:10 justinallenmarsh

Agreed, and with https://github.com/adrienpoly/rubyvideo/pull/163 we should have the full picture for each talk too.

marcoroth avatar Oct 22 '24 18:10 marcoroth

Opened #300 to add artwork. With that we should be able to render a nice looking card!

marcoroth avatar Oct 26 '24 06:10 marcoroth

@jmarsh24 I brought back the card, which we can enhance with #300 once it's merged. But let's merge this in the meantime 🙌🏼

Thank you!

marcoroth avatar Oct 28 '24 04:10 marcoroth