Overload icon indicating copy to clipboard operation
Overload copied to clipboard

Duplicated declaration of samples amount and call to glfwWindowHint

Open maxbrundev opened this issue 5 years ago • 1 comments

Description We declare the amount of subsamples per screen coordinate in our Device and Window Settings classes. We call glfwWindowHint for set the samples amount two times.

Solution We need to test the result of a unique call to glfwWindowHint(GLFW_SAMPLES, settings.samples); and determine wich class will set the samples.

maxbrundev avatar Jun 14 '20 03:06 maxbrundev

glfwWindowHint provides a hint for the next created window, so in this case, the Window has the last word. It might make sense to put most (all?) of the DeviceSettings into WindowSettings.

adriengivry avatar Dec 07 '23 14:12 adriengivry