route-model-binding icon indicating copy to clipboard operation
route-model-binding copied to clipboard

Upgrade lucid to v21 for V6

Open marvin-wtt opened this issue 1 year ago • 4 comments

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING doc
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

marvin-wtt avatar Nov 30 '24 02:11 marvin-wtt

Hey @marvin-wtt! 👋🏻

Thanks a lot for your PR! 🎉 Could you please update the peerDependencies to support both version 20 and 21? That would be great!

RomainLanz avatar Dec 02 '24 09:12 RomainLanz

Could you please update the peerDependencies to support both version 20 and 21?

Sure, done!

marvin-wtt avatar Dec 02 '24 09:12 marvin-wtt

@RomainLanz Sorry for the ping. I'd like to migrate by backend to adonis.js over the holidays. Any chance this gets merged? Fresh V6 projects use lucid v21

marvin-wtt avatar Dec 12 '24 20:12 marvin-wtt

Any updates on this?

marvin-wtt avatar Feb 10 '25 14:02 marvin-wtt

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 01:04 stale[bot]