milo icon indicating copy to clipboard operation
milo copied to clipboard

MWPW-171672: Copy to clipboard for checkout CTAs

Open mirafedas opened this issue 11 months ago • 3 comments

Setting the mas-ff-copy-cta to on in page metadata will display a Copy to Clipboard button next to each checkout CTA on the page. By clicking the Copy to Clipboard button, users can copy the checkout link, e.g. https://milo.adobe.com/tools/ost?osi=-lYm-YaTSZoUgv1gzqCgybgFotLqRsLwf8CgYdvdnsQ&type=checkoutUrl&text=free-trial&workflowStep=segmentation&modal=twp . This functionality is available only on .aem.page, and not on .aem.live.

Resolves: MWPW-171672

Test URLs:

  • Before: https://main--milo--adobecom.aem.page/drafts/mirafedas/commerce-cta-modal-lib?martech=off&georouting=off
  • After: https://mwpw-171672-copy-cta--milo--mirafedas.aem.page/drafts/mirafedas/commerce-cta-modal-lib?martech=off&georouting=off&mep=off

mirafedas avatar May 16 '25 15:05 mirafedas

@mirafedas : Nala Carousel tests are failing on your branch, can you please update your branch with latest stage code base

cc: @narcis-radu @zagi25 @overmyheadandbody

skumar09 avatar May 16 '25 21:05 skumar09

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar May 17 '25 01:05 github-actions[bot]

@mirafedas

  1. Plz fix the PSI check failure
  2. I don't see a "Copy" tooltip , although minor its nice to have...

fyi other than above LGTM

cc @3ch023 @afmicka

Roycethan avatar May 28 '25 00:05 Roycethan

@Roycethan I added a tooltip, and as for PSI check - as this page will never be available for users, we do not need to optimize the performance, so I think we can ignore this check, I'm pretty sure we will never have so many CTAs on one page

mirafedas avatar Jun 02 '25 12:06 mirafedas

@Roycethan I added a tooltip, and as for PSI check - as this page will never be available for users, we do not need to optimize the performance, so I think we can ignore this check, I'm pretty sure we will never have so many CTAs on one page

@mirafedas Thanks for adding tooltip... I would still ask you to fix the psi check, else i doubt it will go through the auto merge to stage workflow since those checks are mandatory in that.

cc @3ch023

Roycethan avatar Jun 02 '25 14:06 Roycethan

Error merging 4171: MWPW-171672: Copy to clipboard for checkout CTAs Pull Request is not mergeable

milo-pr-merge[bot] avatar Jun 03 '25 08:06 milo-pr-merge[bot]

Error merging 4171: MWPW-171672: Copy to clipboard for checkout CTAs Pull Request is not mergeable

milo-pr-merge[bot] avatar Jun 05 '25 09:06 milo-pr-merge[bot]