milo icon indicating copy to clipboard operation
milo copied to clipboard

Gap is seen between promo banner and G-nav when page is scrolled fix

Open patel-prince opened this issue 1 year ago • 2 comments

Brief description of the issue: Gap is seen between promo banner and G-nav when page is scrolled.

Resolves: MWPW-168480

Test URLs:

  • Before: https://main--milo--adobecom.aem.page/?martech=off
  • After: https://mwpw-168480-fix--milo--patel-prince.aem.page/?martech=off

QA URL:

  • https://mwpw-168480-fix--milo--patel-prince.aem.page/drafts/prince/test_urls/page-with-promo?martech=off

Gnav test urls with Promo bar:

  • https://main--dc--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?milolibs=mwpw-168480-fix--milo--patel-prince
  • https://main--bacom--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?milolibs=mwpw-168480-fix--milo--patel-prince
  • https://main--cc--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?milolibs=mwpw-168480-fix--milo--patel-prince

GNav Test URLs

Gnav + Footer + Region Picker modal:

  • Acrobat: https://main--dc--adobecom.hlx.live/acrobat?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • BACOM: https://main--bacom--adobecom.hlx.live/?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • CC: https://main--cc--adobecom.aem.live/creativecloud?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • Milo: https://mwpw-168480-fix--milo--adobecom.aem.page/drafts/blaishram/test-urls/page?martech=off
  • Express: https://main--express-milo--adobecom.aem.live/express/?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • News: https://main--news--adobecom.aem.live/?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • Homepage: https://main--homepage--adobecom.aem.live/homepage/index-loggedout?martech=off&milolibs=mwpw-168480-fix--milo--adobecom

Thin Gnav + ThinFooter + Region Picker dropup:

  • Acrobat: https://main--dc--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • BACOM: https://main--bacom--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • CC: https://main--cc--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • Milo: https://mwpw-168480-fix--milo--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off
  • Express: https://main--express-milo--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • News: https://main--news--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • Homepage: https://main--homepage--adobecom.hlx.page/drafts/blaishram/test-urls/page-gnav-footer-thin?martech=off&milolibs=mwpw-168480-fix--milo--adobecom

Localnav + Promo:

  • Acrobat: https://main--dc--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • BACOM: https://main--bacom--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • CC: https://main--cc--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • Milo: https://mwpw-168480-fix--milo--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off
  • Express: https://main--express-milo--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • News: https://main--news--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-168480-fix--milo--adobecom
  • Homepage: https://main--homepage--adobecom.hlx.page/drafts/blaishram/test-urls/page-with-promo?martech=off&milolibs=mwpw-168480-fix--milo--adobecom

Sticky Branch Banner:

  • URL: https://main--federal--adobecom.aem.page/drafts/blaishram/banner/branch-banner-sticky?martech=off&milolibs=mwpw-168480-fix--milo--adobecom

Inline Branch Banner:

  • URL: https://main--federal--adobecom.aem.page/drafts/blaishram/banner/branch-banner-inline?martech=off&milolibs=mwpw-168480-fix--milo--adobecom

Blog

  • URL: https://main--blog--adobecom.aem.page/?martech=off&milolibs=mwpw-168480-fix--milo--adobecom

RTL Locale

  • URL: https://main--homepage--adobecom.aem.live/mena_ar/homepage/index-loggedout?martech=off&milolibs=mwpw-168480-fix--milo--adobecom

patel-prince avatar Apr 29 '25 12:04 patel-prince

Hi @patel-prince , In the Mobile Firefox browser in landscape mode we are able to see the promobar height is not as expected , please take a look and advise https://main--cc--adobecom.hlx.page/uk/products/elements-family?milolibs=mwpw-168480--milo--patel-prince image

cc : @prativas22

spadmasa avatar May 21 '25 05:05 spadmasa

Hi @patel-prince, observed that the menu name (creative cloud products) appears cut off and is not fully visible in landscape mode. https://main--cc--adobecom.hlx.page/uk/products/elements-family?milolibs=mwpw-168480--milo--patel-prince image

prativas22 avatar May 27 '25 06:05 prativas22

Hi @patel-prince, observed that the menu name (creative cloud products) appears cut off and is not fully visible in landscape mode. https://main--cc--adobecom.hlx.page/uk/products/elements-family?milolibs=mwpw-168480--milo--patel-prince image

You are testing with wrong milolibs value, you are using ?milolibs=mwpw-168480--milo--patel-prince instead you should use ?milolibs=mwpw-168480-fix--milo--patel-prince

patel-prince avatar May 27 '25 13:05 patel-prince

Verified the PR for the gap fix between the Gnav and the promo banner when the page scrolls. https://main--cc--adobecom.hlx.live/uk/products/elements-family?milolibs=mwpw-168480-fix--milo--patel-prince Recording gnav_promo_gap_fix.webm

image image image

Detailed results are added in the ticket https://jira.corp.adobe.com/browse/MWPW-168480

prativas22 avatar May 30 '25 05:05 prativas22