spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[HOLD]chore: update changeset-snapshot-publish script to accept a parameter…

Open blunteshwar opened this issue 10 months ago • 7 comments

… for versioning

Description

Enhanced Changeset Publishing for Snapshots and Beta Releases Changes Updated changeset-snapshot-publish script to accept a parameter for snapshot identification Enhanced beta release workflow to dynamically determine the next beta version Updated version management in the release pipeline Purpose These changes improve our release automation by: Allowing custom snapshot identifiers when publishing test/development versions Automating the beta versioning process to consistently increment beta numbers Centralizing version management in package.json without requiring external scripts Implementation Added parameter support to the snapshot publish command using shell parameter substitution Implemented dynamic beta number determination based on previously published versions Maintained backward compatibility with existing workflows This update primarily affects snapshot releases used for testing purposes, providing a more flexible and maintainable approach to our release pipeline.

Related issue(s)

Motivation and context

How has this been tested?

  • [ ] Test case 1

    1. Go here
    2. Do this
  • [ ] Test case 2

    1. Go here
    2. Do this
  • [ ] Did it pass in Desktop?

  • [ ] Did it pass in Mobile?

  • [ ] Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My code follows the code style of this project.
  • [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

blunteshwar avatar Apr 11 '25 15:04 blunteshwar

⚠️ No Changeset found

Latest commit: abcadcdabcdf9710def37719a8128092decfbc87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 11 '25 15:04 changeset-bot[bot]

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file. If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions[bot] avatar Apr 11 '25 15:04 github-actions[bot]

Tachometer results

Currently, no packages are changed by this PR...

github-actions[bot] avatar Apr 11 '25 15:04 github-actions[bot]

@blunteshwar does this conflict with rubens PR? as in does his PR need to go in first or does this PR? Trying to understand merge order

caseyisonit avatar Apr 11 '25 15:04 caseyisonit

@blunteshwar does this conflict with rubens PR? as in does his PR need to go in first or does this PR? Trying to understand merge order

This is an alternative to ruben's pull request he's trying to achieve the same using snapshot releases, which is meant for testing purpose release and will not generate exact beta versions which we were generating earlier. This Pr leverages the beta release number to generate the exact beta versions without changing existing release functionality

blunteshwar avatar Apr 11 '25 15:04 blunteshwar

.

blunteshwar avatar Apr 11 '25 17:04 blunteshwar

@blunteshwar can this PR be closed?

caseyisonit avatar Oct 24 '25 17:10 caseyisonit