spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

Rectifying failing tests

Open blunteshwar opened this issue 1 year ago • 4 comments

Description

Some tests were failing on main branch on local. This PR will aim at rectifying those failing tests.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [x] If my change required a change to the documentation, I have updated the documentation in this pull request.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

blunteshwar avatar Jul 29 '24 14:07 blunteshwar

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions[bot] avatar Jul 29 '24 14:07 github-actions[bot]

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 228.256 kB 216.566 kB 🏆 216.749 kB
Scripts 57.865 kB 52.053 kB 51.99 kB 🏆
Stylesheet 34.372 kB 30.042 kB 🏆 30.15 kB
Document 6.244 kB 5.464 kB 🏆 5.498 kB
Font 126.989 kB 126.632 kB 🏆 126.736 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

github-actions[bot] avatar Jul 29 '24 14:07 github-actions[bot]

Tachometer results

Chrome

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 473 kB 41.49ms - 42.55ms - unsure 🔍
-2% - +4%
-0.95ms - +1.46ms
branch 430 kB 40.68ms - 42.85ms unsure 🔍
-3% - +2%
-1.46ms - +0.95ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 12.69ms - 13.26ms - unsure 🔍
-0% - +5%
-0.04ms - +0.58ms
branch 441 kB 12.60ms - 12.81ms unsure 🔍
-4% - +0%
-0.58ms - +0.04ms
-
Firefox

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 473 kB 81.98ms - 87.38ms - unsure 🔍
-4% - +5%
-3.39ms - +4.15ms
branch 430 kB 81.66ms - 86.94ms unsure 🔍
-5% - +4%
-4.15ms - +3.39ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 28.68ms - 31.64ms - unsure 🔍
-7% - +7%
-2.01ms - +2.21ms
branch 441 kB 28.56ms - 31.56ms unsure 🔍
-7% - +7%
-2.21ms - +2.01ms
-

github-actions[bot] avatar Jul 29 '24 14:07 github-actions[bot]

Pull Request Test Coverage Report for Build 10905494366

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.212%

Totals Coverage Status
Change from base Build 10905285957: 0.003%
Covered Lines: 32542
Relevant Lines: 32961

💛 - Coveralls

coveralls avatar Aug 29 '24 08:08 coveralls