spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

chore(vscode-settings): remove deprecated property; disable postcss validate

Open cdransf opened this issue 1 year ago • 3 comments

Description

  • Removes deprecated aslant.packageManager setting
  • Adds postcss.validate: false as postcss.validate conflicts with our stylelint and posts

How and where has this been tested?

Verified locally. Removing the following:

"at-rule-no-unknown": [
  true,
  {
    ignoreAtRules: ["extend", "container", "each", "include", "mixin"],
  },
],

Raises a lint violation against at-rule-no-unknown, establishing that ignoreAtRules is being applied (as no exceptions are now being defined in the rule definition).

Restoring the rule then returns our unknownAtRules violation which is attributed to postcss.

Adding postcss.validate: false to the workspace settings resolves the issue. Additionally — removing "extend" from ignoreAtRules and restarting the stylelint server in VS Code causes stylelint to surface a violation — we can then rely on stylelint to provide coverage for syntax violations like this.

To-do list

  • [x] I have read the contribution guidelines.
  • [ ] I have updated relevant storybook stories and templates.
  • [ ] I have tested these changes in Windows High Contrast mode.
  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] ✨ This pull request is ready to merge. ✨

cdransf avatar Oct 24 '24 23:10 cdransf

⚠️ No Changeset found

Latest commit: 58af8d44c67df7d7b789a776397096bdd773642b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 24 '24 23:10 changeset-bot[bot]

🚀 Deployed on https://pr-3325--spectrum-css.netlify.app

github-actions[bot] avatar Oct 24 '24 23:10 github-actions[bot]

File metrics

Summary

Total size: 4.30 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

github-actions[bot] avatar Oct 24 '24 23:10 github-actions[bot]