spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

[Coachmark][a11y]: subtle animation should support prefers-reduced-motion media query

Open majornista opened this issue 2 years ago • 5 comments

Description

Coachmark continues to animate subtly despite the prefers-reduced-motion user preference.

Steps to reproduce

  1. Using Chrome, go to https://opensource.adobe.com/spectrum-css/coachmark.html
  2. Open Developer Tools > Rendering
  3. Under Emulate CSS media feature prefers-reduced-motion, select "prefers-reduced-motion: reduce"
Screen shot of  Developer Tools > Rendering panel with Emulate CSS media feature prefers-reduced-motion picker

Expected behavior

Coachmark elements should not continue to vibrate.

Screenshots

Screen Recording showing continuous animation

Environment

  • Spectrum CSS version: @spectrum-css/[email protected]
  • Browser(s) and OS(s): Chrome 114.0.5735.106 (Official Build) (arm64) on macOS

Additional context

  • https://www.w3.org/WAI/WCAG21/Understanding/animation-from-interactions
  • https://www.w3.org/WAI/WCAG21/Techniques/css/C39

majornista avatar Jun 19 '23 18:06 majornista

@majornista thank you! We're actively working to migrate this component to the new Spectrum Tokens system, and @jenndiaz is working on it in our current sprint. I added a note in her Jira ticket for the migration, so we'll be sure to get this update in with that work.

pfulton avatar Jun 19 '23 23:06 pfulton

Thanks!

majornista avatar Jun 20 '23 21:06 majornista

@majornista Do you have a alternative behavior you'd recommend for the element? Does just stopping the animation (screenshot) lose too much of the original design or do you think this is okay?

Screenshot 2023-06-21 at 2 57 17 PM

jenndiaz avatar Jun 21 '23 21:06 jenndiaz

@majornista any additional thoughts here with regard to @jenndiaz's comment above? We're getting close to merging and releasing this component and want to be sure that we've addressed everything.

pfulton avatar Nov 15 '23 21:11 pfulton

Prefers reduced motion styling added to the coach indicator in the S1 migration for Coach Mark

https://github.com/adobe/spectrum-css/pull/2323/files#diff-8b0768275144772a003e7c7254ed48176d187ad85fd7dcd23c89039529ab54e7R95

jenndiaz avatar Feb 15 '24 18:02 jenndiaz