react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

Fix escape key to close IME in useOverlay

Open ryo-manba opened this issue 1 year ago • 0 comments

Closes https://github.com/adobe/react-spectrum/issues/5921

✅ Pull Request Checklist:

  • [x] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [x] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. Open OS keyboard settings
  2. Add Chinese Pinyin - Simplified
  3. Visit http://localhost:9003/?path=/story/dialog--form&providerSwitcher-express=false&strict=true
  4. Type "ni", a set of suggestions should appear
  5. Press Tab 3x
  6. Press Escape and see the state of the dialog

🧢 Your Project:

ryo-manba avatar Feb 22 '24 14:02 ryo-manba