react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

fix: NaN in slider thumb attributes

Open konsalex opened this issue 1 year ago โ€ข 3 comments

Closes #5859

โœ… Pull Request Checklist:

  • [X] Included link to corresponding React Spectrum GitHub Issue.
  • [X] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [X] Filled out test instructions.
  • [X] Updated documentation (if it already exists for this component).
  • [X] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

Not sure if the tests need updating, followed the PR from here.

Ended up with this syntax as nullish coalescing or logical or did not fit this use.

๐Ÿงข Your Project:

Neo4j, Needle Design System

konsalex avatar Feb 13 '24 09:02 konsalex

GET_BUILD

reidbarber avatar Feb 15 '24 15:02 reidbarber

## API Changes

unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any', access: 'private' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'identifier', name: 'Column' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown type { type: 'link' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' } unknown top level export { type: 'any' }

rspbot avatar Feb 15 '24 15:02 rspbot

Closing as I believe it's been addressed through the comment thread. If not, please feel free to reopen or ping us again.

snowystinger avatar Jun 17 '24 03:06 snowystinger