react-spectrum icon indicating copy to clipboard operation
react-spectrum copied to clipboard

WIP Popover edge position take two

Open ktabors opened this issue 3 years ago โ€ข 1 comments

Closes

tests will probably fail, for a design review

โœ… Pull Request Checklist:

  • [ ] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

ktabors avatar Sep 14 '22 18:09 ktabors

current plan is to merge and do above improvements as followup

ktabors avatar Nov 10 '22 17:11 ktabors

The hide arrow logic is no longer working correctly post merge conflict fix. Seems to be related to the overlay refactor, but don't see a change that would have caused this.

ktabors avatar Nov 11 '22 18:11 ktabors

Fixed by #4220

ktabors avatar Jun 02 '23 20:06 ktabors