react-spectrum-charts icon indicating copy to clipboard operation
react-spectrum-charts copied to clipboard

`vega-embed` relies on `fast-json-patch` which does not get hoisted properly by `parcel`

Open marshallpete opened this issue 1 year ago โ€ข 0 comments

Provide a general summary of the issue here

vega-embed has a dependency on fast-json-patch which does not currently get hoisted correctly in parcel. vega-embed also has vega-lite as a required dependency which is almost a 10MB package that we never use.

๐Ÿค” Expected Behavior?

react-spectrum-charts will work in parcel production builds without special package.json setup.

๐Ÿ˜ฏ Current Behavior

parcel apps need to add an alias to their package.json that points to the index.js file for fast-json-patch instead of the index.mjs file.

๐Ÿ’ Possible Solution

Remove our dependency on vega-embed by reimplementing the necessary parts in react-spectrum-charts

๐Ÿ”ฆ Context

No response

๐Ÿ–ฅ๏ธ Steps to Reproduce

  1. Create a simple parcel app
  2. Add fast-json-patch
  3. Serve with hoisting enabled

Version

v1.10.1

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Mac OS 14.5

๐Ÿงข Your Company/Team

Adobe

๐Ÿ•ท Tracking Issue

No response

marshallpete avatar Jun 11 '24 16:06 marshallpete