helix-cli icon indicating copy to clipboard operation
helix-cli copied to clipboard

`hlx up` should default to the preview domain set in sidekick

Open davidnuescheler opened this issue 2 years ago • 7 comments

it would be great if we could automatically use the custom preview URLs for hlx up, i think this would allow devs at customers that have custom preview URLs to work more intuitively with custom CDN layers that are sitting infront of .page

davidnuescheler avatar Aug 02 '23 17:08 davidnuescheler

thoughts @rofe / @tripodsan ?

davidnuescheler avatar Aug 02 '23 17:08 davidnuescheler

good idea - but there is no possibility to communicate with the sidekick from the helix-cli..... we could call https://admin.hlx.page/sidekick/.../env.json but this would only work for projects w/o admin authentication

tripodsan avatar Aug 03 '23 12:08 tripodsan

let's add a hlx env file with default options in the github repo / root directory.

davidnuescheler avatar Aug 16 '23 16:08 davidnuescheler

let's add a hlx env file with default options in the github repo / root directory.

I'm not a big fan of adding even more configuration to the system. note, that devs already can add a HLX_URL=... in their .env to proxy a specific page

tripodsan avatar Aug 17 '23 05:08 tripodsan

this is fixed.

tripodsan avatar Mar 19 '24 10:03 tripodsan

After testing, AEM up w/out the --url flag doesn't seem to work for customer. It does load adobe origin urls, just not the customer's worker urls

3vil3mpir3 avatar Apr 19 '24 09:04 3vil3mpir3

@3vil3mpir3 please note, that this doesn't work for authenticated projects. I assume that's why it doesn't work for some customers.

tripodsan avatar Apr 22 '24 15:04 tripodsan