commerce-cif-graphql-client
commerce-cif-graphql-client copied to clipboard
ISSUE-43 : Add DEBUG logging for GraphQL Client Cache HIT/MISS or Exc…
Added DEBUG and ERROR logs when there is a Cache HIT or MISS or in case of an exception.
Description
- Added DEBUG and ERROR logs when there is a Cache HIT or MISS or in case of an exception.
- Fixes https://github.com/adobe/commerce-cif-graphql-client/issues/43
Related Issue
Related Issue: https://github.com/adobe/commerce-cif-graphql-client/issues/43
Motivation and Context
To be able to investigate issues when GraphQL Client Cache Configuration is missing or has errors. Especially on AEM 6.5.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] I have signed the Adobe Open Source CLA.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes and the overall coverage did not decrease.
- [ ] All unit tests pass on CircleCi.
- [ ] I ran all tests locally and they pass.
Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
98a9828) 94.84% compared to head (8ea4271) 94.67%.
| Files | Patch % | Lines |
|---|---|---|
| ...ommerce/graphql/client/impl/GraphqlClientImpl.java | 66.66% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #44 +/- ##
============================================
- Coverage 94.84% 94.67% -0.18%
Complexity 180 180
============================================
Files 11 11
Lines 485 488 +3
Branches 63 63
============================================
+ Hits 460 462 +2
- Misses 21 22 +1
Partials 4 4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thanks much for this, will help triage miss(ed) cache hits and other cache weirdness