aem-project-archetype icon indicating copy to clipboard operation
aem-project-archetype copied to clipboard
verified publisher icon adobe

Adding custom header/footer libs for SPA remotepage component

Open sharanyavinod opened this issue 4 years ago • 2 comments

Description

Adding custom header/footer libs for remotepage component similar to existing page component

Motivation and Context

Include generated project styles such as grid layout as well as the required meta properties

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

sharanyavinod avatar Aug 30 '21 09:08 sharanyavinod

@niekraaijmakers Could you review, please?

sharanyavinod avatar Aug 30 '21 11:08 sharanyavinod

Code looks good, just curious why these 2 files are needed? LGTM though

niekraaijmakers avatar Aug 31 '21 13:08 niekraaijmakers