aem-core-forms-components icon indicating copy to clipboard operation
aem-core-forms-components copied to clipboard

FORMS-14419 Fix adding items in loop

Open dmaurya929 opened this issue 1 year ago • 5 comments

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes and the overall coverage did not decrease.
  • [ ] All unit tests pass on CircleCi.
  • [ ] I ran all tests locally and they pass.

dmaurya929 avatar May 14 '24 21:05 dmaurya929

@sakshi-arora1 please review this change, if looks good I'll add test

dmaurya929 avatar May 14 '24 21:05 dmaurya929

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

adobe-bot avatar May 14 '24 21:05 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75

adobe-bot avatar May 14 '24 21:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 14 '24 21:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 14 '24 22:05 adobe-bot

@sakshi-arora1 build is failing for this PR, I haven't made any changes in the bundle but it is asking to increase the package version. Please help me to understand

[INFO]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
[INFO] = ================================================== ========== ========== ========== ========== ==========
[INFO] * com.adobe.cq.forms.core.components.models.aemform  major      1.4.0      1.5.0      2.0.0      Version increase required

[ERROR] Failed to execute goal org.apache.felix:maven-bundle-plugin:5.1.4:baseline (baseline) on project core-forms-components-core: Baseline failed, see generated report -> [Help 1]

dmaurya929 avatar Jun 20 '24 14:06 dmaurya929

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 92 96 96 75

adobe-bot avatar Jul 24 '24 10:07 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75

adobe-bot avatar Jul 24 '24 10:07 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Jul 24 '24 10:07 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Jul 24 '24 10:07 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious

adobe-bot avatar Jul 24 '24 10:07 adobe-bot