aem-core-forms-components icon indicating copy to clipboard operation
aem-core-forms-components copied to clipboard

thank you msg overriding and role main adding

Open rajatofficial opened this issue 1 year ago • 31 comments

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] I have signed the Adobe Open Source CLA.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes and the overall coverage did not decrease.
  • [ ] All unit tests pass on CircleCi.
  • [ ] I ran all tests locally and they pass.

rajatofficial avatar May 07 '24 08:05 rajatofficial

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (76c66be) to head (49941cb).

Files Patch % Lines
...ents/internal/models/v1/AbstractComponentImpl.java 90.00% 0 Missing and 1 partial :warning:
...onents/internal/models/v2/aemform/AEMFormImpl.java 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1222      +/-   ##
============================================
+ Coverage     81.39%   81.45%   +0.06%     
- Complexity      817      827      +10     
============================================
  Files            94       95       +1     
  Lines          2198     2216      +18     
  Branches        301      302       +1     
============================================
+ Hits           1789     1805      +16     
  Misses          253      253              
- Partials        156      158       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 07:05 codecov[bot]

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

adobe-bot avatar May 15 '24 07:05 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75

adobe-bot avatar May 15 '24 07:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 15 '24 07:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 15 '24 07:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 15 '24 07:05 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75

adobe-bot avatar May 17 '24 08:05 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

adobe-bot avatar May 17 '24 08:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 17 '24 08:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 20 '24 11:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 20 '24 11:05 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75

adobe-bot avatar May 22 '24 05:05 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

adobe-bot avatar May 22 '24 05:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 05:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 05:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 05:05 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 95 96 100 75

adobe-bot avatar May 22 '24 07:05 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

adobe-bot avatar May 22 '24 07:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 07:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 07:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 07:05 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75

adobe-bot avatar May 22 '24 08:05 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

adobe-bot avatar May 22 '24 08:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 08:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 08:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 08:05 adobe-bot

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75

adobe-bot avatar May 22 '24 11:05 adobe-bot

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

adobe-bot avatar May 22 '24 11:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 11:05 adobe-bot

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

adobe-bot avatar May 22 '24 11:05 adobe-bot