aem-boilerplate icon indicating copy to clipboard operation
aem-boilerplate copied to clipboard

refactor: use window.location as base for url construction

Open fkakatie opened this issue 2 years ago • 3 comments

Replaces instances of creating URL objects with a single argument with the two-argument form, using window.location as the base URL. Ensures that relative URLs are resolved against the current browser location for consistent handling.

Test URLs:

  • Before: https://main--aem-boilerplate--adobe.hlx.live/
  • After: https://relative-paths--aem-boilerplate--adobe.hlx.live/

fkakatie avatar Dec 07 '23 19:12 fkakatie

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

  • [ ] Re-run PSI Checks

aem-code-sync[bot] avatar Dec 07 '23 19:12 aem-code-sync[bot]

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

aem-code-sync[bot] avatar Dec 07 '23 19:12 aem-code-sync[bot]

@fkakatie this has now been done with #346

buuhuu avatar Apr 19 '24 17:04 buuhuu