aem-angular-editable-components icon indicating copy to clipboard operation
aem-angular-editable-components copied to clipboard

feature(component-directive): make the component directive extensible

Open niekraaijmakers opened this issue 4 years ago • 2 comments

Description

Adding some hooks that can be used to extend the component directive class. This will enable the content fragment component to reuse this logic instead of duplicating it.

Pending PR : https://github.com/adobe/aem-angular-editable-components/pull/46

Related Issue

https://github.com/adobe/aem-angular-editable-components/issues/43

How Has This Been Tested?

Unit tested

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have signed the Adobe Open Source CLA.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

niekraaijmakers avatar Jun 14 '21 14:06 niekraaijmakers

Codecov Report

Merging #48 (dddf57a) into master (0b61f1d) will not change coverage. The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files          10       10           
  Lines         171      171           
  Branches       29       29           
=======================================
  Hits          150      150           
  Misses         14       14           
  Partials        7        7           
Impacted Files Coverage Δ
src/lib/layout/aem-component.directive.ts 82.85% <69.23%> (ø)
src/lib/layout/component-mapping.ts 88.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b61f1d...dddf57a. Read the comment docs.

codecov[bot] avatar Jun 15 '21 12:06 codecov[bot]

hi, there's news?

fdambrosio avatar Sep 22 '23 10:09 fdambrosio