Snap.svg icon indicating copy to clipboard operation
Snap.svg copied to clipboard

Fix matrix parsing.

Open pokebadgerswithspoon opened this issue 8 years ago • 1 comments

Blank symbol in front of matrix was treated an extra paramter. This commit trims all the whitespace around content of brackets.

Example

This was handled incorrectly Was: matrix( 1, 0, 0, 1, 50.45,55.65) snap.svg.js:2814 Became: m,,1,0,0,1,50.45,55.65 snap.svg.js:2816

Mark the double comma!

SVG

To test a bug you need to create an html file with SVG content which has matrix transform, say scaled 50%. Wrap it with Snap, select transformed element and try to rotate it. Scale will reset to 100%. Check example below and note space in front of 0.5.

<g transform="matrix( 0.5,0,0,0.5, 0,0) " id="content">....something simple yo'd like to rotate...</g>

pokebadgerswithspoon avatar Oct 23 '17 17:10 pokebadgerswithspoon

Hey @pokebadgerswithspoon - your build was failing for the same reason as mine, some code formatting in equal.js that grunt had no problem with but the cli did. I updated the equal.js file in https://github.com/adobe-webplatform/Snap.svg/pull/581 and my build is passing fine. If you follow the code there it should also let your build pass 🙂

dominicfraser avatar Jan 20 '18 16:01 dominicfraser