php-jwt icon indicating copy to clipboard operation
php-jwt copied to clipboard

improved code style

Open Tautve opened this issue 3 years ago • 2 comments

improved code style by importing some use statements, substr replacing with strpos

Tautve avatar Oct 02 '22 17:10 Tautve

helo, thanks for this PR. im gonna accept this PR if the build passes and you kindly can format the commit message to angular format (as are other commits before) : https://github.styleci.io/analyses/prOrAR

however since it is not feature or fix or significant refactor - i don't know if it should be #hacktoberfest-accepted though.

edit: since you are a first time contributor, as a courtesy i will mark it as #hacktoberfest-accepted :) (pls address the comment above though)

adhocore avatar Oct 03 '22 13:10 adhocore

seems you didnt check https://github.styleci.io/analyses/prOrAR also might need to rebase commit msg for this one a7037d6


da7158a should be:

refactor: changed the order of use statements in JWT.php

adhocore avatar Oct 04 '22 13:10 adhocore