spark-android icon indicating copy to clipboard operation
spark-android copied to clipboard
verified publisher icon adevinta

chore(deps): bump app.cash.paparazzi from 1.3.1 to 1.3.3

Open dependabot[bot] opened this issue 2 years ago • 13 comments

Bumps app.cash.paparazzi from 1.3.1 to 1.3.3.

Release notes

Sourced from app.cash.paparazzi's releases.

1.3.3

New

  • Migrate Paparazzi to layoutlib Hedgehog 2023.1.1
  • Compose 1.5.8
  • Kotlin 1.9.22
  • [Gradle Plugin] Gradle 8.6
  • [Gradle Plugin] Android Gradle Plugin 8.2.1

Fixed

  • Update the DeviceConfig screenWidth internally for accessibility tests
  • Fix variant caching issues in new resource/asset loading mechanisms
  • Remove legacy resources/assets loading mechanism
  • Set HardwareConfig width and height based on orientation
  • Apply round screen qualifier to device config
  • Restrict Paparazzi's public API
  • Remove obsolete NEXUS_5_LAND DeviceConfig
  • Fix formatting so that all digits show upon failure
  • Stop resolving dependencies at configuration time
  • Use our own internal HandlerDispatcher for Compose Ui tests
  • Include generated string resources
  • Reset logger to prevent swallowing exceptions

Kudos to @​gamepro65, @​kevinzheng-ap, @​BrianGardnerAtl, @​adamalyyan, and others for contributions this release!

1.3.2

NOTE: Due to a known issue with how Guava now publishes its artifact, you will need to apply the following snippet workaround to your root build.gradle (Groovy-based, Kotlin impls will vary slightly):

subprojects {
  plugins.withId("app.cash.paparazzi") {
    // Defer until afterEvaluate so that testImplementation is created by Android plugin.
    afterEvaluate {
      dependencies.constraints {
        add("testImplementation", "com.google.guava:guava") {
          attributes {
            attribute(
              TargetJvmEnvironment.TARGET_JVM_ENVIRONMENT_ATTRIBUTE,
              objects.named(TargetJvmEnvironment, TargetJvmEnvironment.STANDARD_JVM)
            )
          }
          because("LayoutLib and sdk-common depend on Guava's -jre published variant." +
            "See https://github.com/cashapp/paparazzi/issues/906.")
        }
      }
    }
  }
}

See also: google/guava#6801.

New

... (truncated)

Changelog

Sourced from app.cash.paparazzi's changelog.

[1.3.3] - 2024-03-01

New

  • Migrate Paparazzi to layoutlib Hedgehog 2023.1.1
  • Compose 1.5.8
  • Kotlin 1.9.22
  • [Gradle Plugin] Gradle 8.6
  • [Gradle Plugin] Android Gradle Plugin 8.2.1

Fixed

  • Update the DeviceConfig screenWidth internally for accessibility tests
  • Fix variant caching issues in new resource/asset loading mechanisms
  • Remove legacy resources/assets loading mechanism
  • Set HardwareConfig width and height based on orientation
  • Apply round screen qualifier to device config
  • Restrict Paparazzi's public API
  • Remove obsolete NEXUS_5_LAND DeviceConfig
  • Fix formatting so that all digits show upon failure
  • Stop resolving dependencies at configuration time
  • Use our own internal HandlerDispatcher for Compose Ui tests
  • Include generated string resources
  • Reset logger to prevent swallowing exceptions

Kudos to @​gamepro65, @​kevinzheng-ap, @​BrianGardnerAtl, @​adamalyyan, and others for contributions this release!

[1.3.2] - 2024-01-13

NOTE: Due to a known issue with how Guava now publishes its artifact, you will need to apply the following snippet workaround to your root build.gradle:

subprojects {
  plugins.withId("app.cash.paparazzi") {
    // Defer until afterEvaluate so that testImplementation is created by Android plugin.
    afterEvaluate {
      dependencies.constraints {
        add("testImplementation", "com.google.guava:guava") {
          attributes {
            attribute(
              TargetJvmEnvironment.TARGET_JVM_ENVIRONMENT_ATTRIBUTE,
              objects.named(TargetJvmEnvironment, TargetJvmEnvironment.STANDARD_JVM)
            )
          }
          because("LayoutLib and sdk-common depend on Guava's -jre published variant." +
            "See https://github.com/cashapp/paparazzi/issues/906.")
        }
      }
    }
  }
}

See also: google/guava#6801.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Mar 01 '24 14:03 dependabot[bot]

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: validation
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android dependencyGuard 8.7 :white_check_mark: Build Scan NOT_PUBLISHED
spark-android spotlessCheck :build-logic:spotlessCheck 8.7 :x: Build Scan NOT_PUBLISHED

github-actions[bot] avatar Apr 05 '24 12:04 github-actions[bot]

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.7 :white_check_mark: Build Scan NOT_PUBLISHED
spark-android globalCiUnitTest verifyPaparazziRelease 8.7 :x: Build Scan NOT_PUBLISHED

github-actions[bot] avatar Apr 05 '24 12:04 github-actions[bot]

🚨 UI regression detected! Checkout the paparazzi-delta artifact. If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

github-actions[bot] avatar Apr 05 '24 13:04 github-actions[bot]

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.7 :white_check_mark: Build Scan NOT_PUBLISHED
spark-android globalCiUnitTest verifyPaparazziRelease 8.7 :x: Build Scan NOT_PUBLISHED

github-actions[bot] avatar Apr 05 '24 13:04 github-actions[bot]

@spark-ui-bot paparazzi golden images

SimonMarquis avatar Apr 05 '24 13:04 SimonMarquis

@soulcramer it is because Paparazzi now supports pseudolocalisation, and we used to specify this in the paparazzi rule: https://github.com/adevinta/spark-android/blob/7d262501606d0d2a3f729bbd323f58fcee2775e4/spark-screenshot-testing/src/test/kotlin/com/adevinta/spark/PaparazziRule.kt#L73

What should we do?

SimonMarquis avatar Apr 05 '24 15:04 SimonMarquis

Let's remove the pseudolocalisation from the rule 🤔

soulcramer avatar Apr 05 '24 15:04 soulcramer

However for the others diffs they seems normal to me since they're bug fixes from paparazzi (the device orientation being taken into account finally) and the upgrade to layout lib (the textlink annotated tring is finally rendered as on device)

soulcramer avatar Apr 05 '24 15:04 soulcramer

@spark-ui-bot paparazzi

SimonMarquis avatar Apr 05 '24 16:04 SimonMarquis

@spark-ui-bot paparazzi

kazaky avatar May 06 '24 11:05 kazaky

🚨 UI regression detected! Checkout the paparazzi-delta artifact. If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

github-actions[bot] avatar May 06 '24 13:05 github-actions[bot]

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.7 :white_check_mark: Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.7 :x: Build Scan not published

github-actions[bot] avatar May 06 '24 13:05 github-actions[bot]

@spark-ui-bot paparazzi

SimonMarquis avatar May 06 '24 13:05 SimonMarquis

A newer version of app.cash.paparazzi exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot[bot] avatar May 24 '24 04:05 dependabot[bot]