adeekshith
Feature/306/feature to add custom package
Tried this branch. Here are some problems that I found:
- Watomatic not detecting the app is installed, although it is (I suppose this is also the reason why the app icon is not shown).
- Adding the same package name two times results in the app crashing.
- Changing enabled apps to a custom one does not update the main screen until a restart.
Also some suggestions:
- Move the option to add packages to the enabled apps screen
- Add the option to remove a custom package
I can give more info or explain better if something is unclear, let me know!
~Known issue : Select/Deselect any item and scroll up/down then the state is missing first time - Working on it -- Resolved~
- [x] List segregation/sorting - b8d314b ~- [ ] Show alert dialog when pressed back without saving~ this is not needed as we are saving on each click
https://user-images.githubusercontent.com/16569510/126735159-ce6017da-8fda-45d5-b45a-4da49715e9db.mp4
@spuday90 Can you also add a warning dialog when floating "+" button is clicked. Something like "Not tested to work with apps in the list and can cause unintended issues. Use at your own risk." With cancel and accept buttons.
@spuday90 Can you also add a warning dialog when floating "+" button is clicked. Something like "Not tested to work with apps in the list and can cause unintended issues. Use at your own risk." With cancel and accept buttons.
Added in abb51ae
Removed "Use at your own risk" its looking as if device can be damaged or so. Feel free to add it if u think is needed
Changed the UI to be in sync with contact selector
Tested this branch again, everything works right except for the installed apps list, which is weird (see screenshot). I imagine it is because of the rtl approach, so I would suggest using the method shown here, or just using a TextView + Checkbox instead, which I can implement if you are busy.
Tested this branch again, everything works right except for the installed apps list, which is weird (see screenshot). I imagine it is because of the rtl approach, so I would suggest using the method shown here, or just using a TextView + Checkbox instead, which I can implement if you are busy.
Hi @hegocre , Thanks for reporting the issue. Its behaving differently on different devices. I'm just checking for any better solution, if couldn't find any will implement what you have suggested i.e using separate textview+checkbox.
Fixed in 6e19f99 @hegocre Please test now
It is fixed indeed. Now I'm facing a couple of issues
- App names are not visible on dark theme, can be fixed by changing https://github.com/adeekshith/watomatic/blob/6e19f99bf82231362345ed144bc575f0020db1e1/app/src/main/res/layout/installed_apps_list.xml#L28 with
android:textColor="?colorOnSurface" - Apps are still not detected as installed on the enabled apps selector, as shown on the media below:
Looks like it's checking the app against the SUPPORTED_APPS constant here https://github.com/adeekshith/watomatic/blob/6e19f99bf82231362345ed144bc575f0020db1e1/app/src/main/java/com/parishod/watomatic/model/utils/Constants.kt#L29-L33 instead of checking against installed apps.
Other than that, great work, I think it's nearly working perfectly, and it will be a great addition to Watomatic.
Hi @hegocre, Yes app not installed is a known issue, Earlier we didn't had the query_all package permission so was not able to detect app. I will fix that.
Is there an eta, of when this will be added? This would also solve quite a few other requests such as support for messenger lite, discord and telegram.
Merged main into this to solve merge conflicts, this should be tested. And maybe release a new version? There are some nice changes since the last one.
Is there an eta, of when this will be added? This would also solve quite a few other requests such as support for messenger lite, discord and telegram.
Main reason for not merging this is Google Play has new policies regarding apps having permission to access entire apps list. We are now required to apply to them separately with justification, etc for this. And then they would scrutinize the app and websites before giving permissions. Some of the apps recently got removed from Play store for having a donation button on the website. Watomatic has that too so need to figure out having an alternative URL for Play Store users which does not show Donation button. It is not clear we are violating Play Store policies but there is a gray area there. Need to clear those bureaucratic hurdles before this can merged
Merged main into this to solve merge conflicts, this should be tested. And maybe release a new version? There are some nice changes since the last one.
Thank you @hegocre 🙌
Will make a release next week. Thats true, its long overdue 😊 Will merge this PR after the release though because of this: https://github.com/adeekshith/watomatic/pull/340#issuecomment-977984680