flower icon indicating copy to clipboard operation
flower copied to clipboard

fix(baselines) Fix dimension order in weight slicing for OD layers

Open QVQZZZ opened this issue 1 year ago • 1 comments

Issue

Description

Weight slicing for OD layers has the input and output dimensions reversed.

In the weight parameters of Linear and Conv layers, the first dimension should be out_dim, and the second dimension should be in_dim.

Related issues/PRs

Proposal

Explanation

Reversed the order of input and output dimensions in the weight slicing for OD layers.

Checklist

  • [ ] Implement proposed change
  • [ ] Write tests
  • [ ] Update documentation
  • [ ] Make CI checks pass
  • [ ] Ping maintainers on Slack (channel #contributions)

Any other comments?

QVQZZZ avatar Sep 13 '24 17:09 QVQZZZ

Thanks for opening the PR @QVQZZZ , let me loop in @stevelaskaridis and @SamuelHorvath who are the masterminds behind FjORD and added the baseline: what do you think about this 2-lines change?

jafermarq avatar Oct 10 '24 08:10 jafermarq