Adam Johnson

Results 78 comments of Adam Johnson

> Do we need a more solid-styled play button and less transparency for visibility over any background instead? In dark color contexts, the play button could indeed have more contrast....

> pf-chip composes into pf-text-input for things like search. will rh-chip do the same? Was the `` + `` composition use case discussed elsewhere with regards to accessibility? This is...

@coreyvickery: Thanks for putting this design together. It's very helpful! I have a few questions for you. I put together a little [scratchpad demo](https://codepen.io/adamjohnson/pen/ogNNpKK) to help clarify some things with...

@coreyvickery: Thanks for this document! It provides some much-needed clarifications. ### RE: Truncated Chip Text Since the text is in the light DOM and can be styled by end users,...

> Are you proposing no radio functionality, but checkbox instead? Or what do we do here? Yes, for now rh-chip will only have checkbox functionality due to the concerns outlined...

Focus is correctly applied with the implementation of the native `` in #2078.

Indeed, I was just going to mention that we're missing a Figma for this component. Also relevant for the design phase: `` is likely made for freeform content (eg: primary...

![Priority Nav attributes](https://user-images.githubusercontent.com/575865/101104448-227fc780-3599-11eb-8a0d-d2ed71f6c0e7.png) I looked at this too. Tried using this sans-Bootstrap but it appears Bootstrap is indeed still handling the interaction layer. This includes toggling dropdown classes, `aria-expanded`, and...

> @alypilkons I thought we increased the size of the text to 18px on large viewports? RE: page styles overriding component styles. You can do this: ```css #body ::slotted(p) {...

FYI I am picking this up with the goal of getting into Charmander.