Adafruit_SensorLab icon indicating copy to clipboard operation
Adafruit_SensorLab copied to clipboard

added mlx90393 mag support

Open maxxmudd opened this issue 5 years ago • 4 comments

Adafruit_SensorLab.cpp -added a detectMLX90393 method -modified the getMagnetometer method to include detectMLX90393 condition

Adafruit_SensorLab.h -set the file to include the Adafruit_MLX90393 header file -added a detectMLX90393 boolean -added pointer to Adafruit_MLX90393 class, set to NULL

Comments: -these changes have been tested using the mag_hardiron_simplecal.ino example

maxxmudd avatar Jan 01 '21 01:01 maxxmudd

hihi we can review once it passes CI see errors by clicking DETAILS on the CI failures

for example, please add the new dependancy here https://github.com/adafruit/Adafruit_SensorLab/blob/master/library.properties

ladyada avatar Jan 01 '21 23:01 ladyada

ok! next run clang-format and/or write any missing doxygen https://learn.adafruit.com/contribute-to-arduino-with-git-and-github

ladyada avatar Jan 02 '21 05:01 ladyada

I will be doing a bit more digging on this before submitting again. Thank you for being patient and giving me feedback.

maxxmudd avatar Jan 02 '21 07:01 maxxmudd

you can do it!! 👍

ladyada avatar Jan 02 '21 19:01 ladyada